linux-kernel - Re: [PATCH] watchdog: ath79

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a20426b8-921f-f3fa-a106-7ee7cdddacb3@roeck-us.net>
Date:   Wed, 5 Oct 2016 06:18:24 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Wim Van Sebroeck <wim@...ana.be>
Cc:     linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
        Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] watchdog: ath79_wdt: fix build failure

On 10/04/2016 10:28 PM, Sudip Mukherjee wrote:
> The build of mips ath79_defconfig was failing with the error:
> drivers/watchdog/ath79_wdt.c:164:5:
> 	error: implicit declaration of function 'get_user'
> drivers/watchdog/ath79_wdt.c:196:3:
> 	error: implicit declaration of function 'copy_to_user'
> drivers/watchdog/ath79_wdt.c:201:3:
> 	error: implicit declaration of function 'put_user'
>
> Quoting Al Viro - "another victim of indirect include chains"
>
> Fixes: 58a8f3b69e07 ("mips: separate extable.h, switch module.h to it")
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>
> build log is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/164834126
>
>  drivers/watchdog/ath79_wdt.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/ath79_wdt.c b/drivers/watchdog/ath79_wdt.c
> index 835d310..e2209bf 100644
> --- a/drivers/watchdog/ath79_wdt.c
> +++ b/drivers/watchdog/ath79_wdt.c
> @@ -35,6 +35,7 @@
>  #include <linux/err.h>
>  #include <linux/of.h>
>  #include <linux/of_platform.h>
> +#include <linux/uaccess.h>
>
>  #define DRIVER_NAME	"ath79-wdt"
>
>