[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.20.1610051538310.8953@nanos>
Date: Wed, 5 Oct 2016 15:38:52 +0200 (CEST)
From: Thomas Gleixner <tglx@...utronix.de>
To: Sinan Kaya <okaya@...eaurora.org>
cc: linux-acpi@...r.kernel.org, rjw@...ysocki.net, bhelgaas@...gle.com,
ravikanth.nalla@....com, linux@...nbow-software.org,
timur@...eaurora.org, cov@...eaurora.org, jcm@...hat.com,
alex.williamson@...hat.com, linux-pci@...r.kernel.org,
agross@...eaurora.org, linux-arm-msm@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, wim@....tudelft.nl,
Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
Ingo Molnar <mingo@...hat.com>,
"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 3/3] Revert "ACPI,PCI,IRQ: remove SCI penalize
function"
On Tue, 4 Oct 2016, Sinan Kaya wrote:
> The SCI function was removed in two steps (first refactor and then remove).
> This patch does the revert in one step.
>
> The commit 103544d86976 ("ACPI,PCI,IRQ: reduce resource requirements")
> refactored the original code so that SCI penalty is calculated dynamically
> by the time get_penalty function is called. This patch does a partial
> revert for the SCI functionality only.
>
> The commit 9e5ed6d1fb87 ("ACPI,PCI,IRQ: remove SCI penalize function") is
> for the removal of the function. SCI penalty API was replaced by the
> runtime penalty calculation based on the value of
> acpi_gbl_FADT.sci_interrupt.
>
> The IRQ type does not get updated at the right time for some platforms and
> results in incorrect penalty assignment for PCI IRQs as
> irq_get_trigger_type returns the wrong type.
>
> The register_gsi function delivers the IRQ found in the ACPI table to
> the interrupt controller driver. Penalties are calculated before a
> link object is enabled to find out which interrupt has the least number
> of users. By the time penalties are calculated, the IRQ is not registered
> yet and the API returns the wrong type.
>
> Tested-by: Jonathan Liu <net147@...il.com>
> Tested-by: Ondrej Zary <linux@...nbow-software.org>
> Link: https://lkml.org/lkml/2016/10/4/283
> Signed-off-by: Sinan Kaya <okaya@...eaurora.org>
Acked-by: Thomas Gleixner <tglx@...utronix.de>
Powered by blists - more mailing lists