linux-kernel - Re: [PATCH v2] arm: Added support for getcpu() vDSO using TPIDRURW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161005195359.GR1041@n2100.armlinux.org.uk>
Date:   Wed, 5 Oct 2016 20:53:59 +0100
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Robin Murphy <robin.murphy@....com>
Cc:     Fredrik Markström 
        <fredrik.markstrom@...il.com>, Mark Rutland <mark.rutland@....com>,
        Kees Cook <keescook@...omium.org>,
        Arnd Bergmann <arnd@...db.de>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Nicolas Pitre <nico@...aro.org>,
        Will Deacon <will.deacon@....com>, kristina.martsenko@....com,
        linux-kernel@...r.kernel.org,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Chris Brandt <chris.brandt@...esas.com>,
        Michal Marek <mmarek@...e.com>,
        Zhaoxiu Zeng <zhaoxiu.zeng@...il.com>,
        linux-arm-kernel@...ts.infradead.org,
        Jonathan Austin <jonathan.austin@....com>
Subject: Re: [PATCH v2] arm: Added support for getcpu() vDSO using TPIDRURW

On Wed, Oct 05, 2016 at 06:48:05PM +0100, Robin Murphy wrote:
> On 05/10/16 17:39, Fredrik Markström wrote:
> > The approach I suggested below with the vDSO data page will obviously
> > not work on smp, so suggestions are welcome.
> 
> Well, given that it's user-writeable, is there any reason an application
> which cares couldn't simply run some per-cpu threads to call getcpu()
> once and cache the result in TPIDRURW themselves? That would appear to
> both raise no compatibility issues and work with existing kernels.

There is - the contents of TPIDRURW is thread specific, and it moves
with the thread between CPU cores.  So, if a thread was running on CPU0
when it cached the getcpu() value in TPIDRURW, and then migrated to CPU1,
TPIDRURW would still contain 0.

I'm also not in favour of changing the TPIDRURW usage to be a storage
repository for the CPU number - it's far too specific a usage and seems
like a waste of hardware resources to solve one problem.  As Mark says,
it's an ABI breaking change too, even if it is under a config option.

Take a moment to consider distro kernels: how should they set this
config option - should they enable it to get faster getcpu() or should
they disable it to retain existing compatibility to prevent userspace
breakage.  Who can advise them to make the right decision?  Kernel
developers can't, because the usage of this register is purely a
userspace issue right now, and kernels devs don't know what use it's
been put to.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.