linux-kernel - Re: [PATCH] fs/block_dev.c: return the right error in thaw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b9661487-676a-ac3f-43b3-8559e88af06f@fb.com>
Date:   Wed, 5 Oct 2016 14:35:33 -0600
From:   Jens Axboe <axboe@...com>
To:     Jan Kara <jack@...e.cz>, Pierre Morel <pmorel@...ux.vnet.ibm.com>
CC:     <viro@...iv.linux.org.uk>, <linux-kernel@...r.kernel.org>,
        <linux-fsdevel@...r.kernel.org>, <mguzik@...hat.com>,
        <farman@...ux.vnet.ibm.com>, <cornelia.huck@...ibm.com>
Subject: Re: [PATCH] fs/block_dev.c: return the right error in thaw_bdev()

On 10/04/2016 03:06 AM, Jan Kara wrote:
> On Tue 04-10-16 10:53:40, Pierre Morel wrote:
>> When triggering thaw-filesystems via magic sysrq, the system enters a
>> loop in do_thaw_one(), as thaw_bdev() still returns success if
>> bd_fsfreeze_count == 0. To fix this, let thaw_bdev() always return
>> error (and simplify the code a bit at the same time).
>>
>> Reviewed-by: Eric Farman <farman@...ux.vnet.ibm.com>
>> Reviewed-by: Cornelia Huck <cornelia.huck@...ibm.com>
>> Signed-off-by: Pierre Morel <pmorel@...ux.vnet.ibm.com>
>
> The patch looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@...e.cz>
>
> Jens, can you please merge this patch? Thanks!

Added, thanks all.

-- 
Jens Axboe