linux-kernel - Re: cxl: replace loop with for_each_child_of_node(), remove unneeded of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3spfzw6LSRz9t0t@ozlabs.org>
Date:   Wed,  5 Oct 2016 13:36:28 +1100 (AEDT)
From:   Michael Ellerman <patch-notifications@...erman.id.au>
To:     Andrew Donnellan <andrew.donnellan@....ibm.com>,
        linuxppc-dev@...ts.ozlabs.org
Cc:     clombard@...ux.vnet.ibm.com, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org, fbarrat@...ux.vnet.ibm.com,
        julia.lawall@...6.fr, imunsie@....ibm.com,
        elfring@...rs.sourceforge.net
Subject: Re: cxl: replace loop with for_each_child_of_node(), remove unneeded of_node_put()

On Fri, 2016-29-07 at 03:55:34 UTC, Andrew Donnellan wrote:
> Rewrite the cxl_guest_init_afu() loop in cxl_of_probe() to use
> for_each_child_of_node() rather than a hand-coded for loop.
> 
> Remove the useless of_node_put(afu_np) call after the loop, where it's
> guaranteed that afu_np == NULL.
> 
> Reported-by: SF Markus Elfring <elfring@...rs.sourceforge.net>
> Reported-by: Julia Lawall <julia.lawall@...6.fr>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@....ibm.com>
> Reviewed-by: Frederic Barrat <fbarrat@...ux.vnet.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/735840b44bcc998e2574faf63d1aaa

cheers