linux-kernel - Re: [PATCH] staging: speakup: Replaced obsolete simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161005211109.GD7253@var>
Date:   Wed, 5 Oct 2016 23:11:09 +0200
From:   Samuel Thibault <samuel.thibault@...-lyon.org>
To:     Jitendra Khasdev <jkhasdev@...il.com>
Cc:     w.d.hubbs@...il.com, chris@...-brannons.com, kirk@...sers.ca,
        gregkh@...uxfoundation.org, bankarsandhya512@...il.com,
        saurabh.truth@...il.com, amitoj1606@...il.com,
        speakup@...ux-speakup.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: speakup: Replaced obsolete simple_strtoul

Hello,

Jitendra Khasdev, on Thu 06 Oct 2016 02:02:58 +0530, wrote:
> From: Jitendra Kumar Khasdev <jkhasdev@...il.com>
> 
> This patch is for replacing obsolete simple_strtoul to kstrtoul which remove warning produce by checkpatch.

> +	unsigned long val;
> +
> +	if (kstrtoul(start, 10, &val))
> +		return NULL;
>  
> -	val = simple_strtoul(skip_spaces(start), &start, 10);
>  	if (*start == ',')

simple_strtoul modifies start, so you can't just replace it with
kstrtoul.

Samuel