linux-kernel - RE: [PATCH v2 5/5] selftests/pstore: add testcases for multiple pmsg instances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F89ECF87BC754A49BB74E794F6A0EC2FF6827A@GSjpTKYDCembx31.service.hitachi.net>
Date:   Wed, 5 Oct 2016 04:14:14 +0000
From:   岩松信洋 / IWAMATSU，NOBUHIRO 
        <nobuhiro.iwamatsu.kw@...achi.com>
To:     Kees Cook <keescook@...omium.org>
CC:     Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        "Tony Luck" <tony.luck@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Mark Salyzyn <salyzyn@...roid.com>,
        阿口誠司 / AGUCHI，SEIJI 
        <seiji.aguchi.tr@...achi.com>, Shuah Khan <shuahkh@....samsung.com>
Subject: RE: [PATCH v2 5/5] selftests/pstore: add testcases for multiple
 pmsg instances

Hi,

> -----Original Message-----
> From: keescook@...gle.com [mailto:keescook@...gle.com] On Behalf Of Kees
> Cook
> Sent: Friday, September 09, 2016 6:56 AM
> To: 岩松信洋 / IWAMATSU，NOBUHIRO
> Cc: Anton Vorontsov; Colin Cross; Tony Luck; LKML; Hiraku Toyooka; Mark
> Salyzyn; 阿口誠司 / AGUCHI，SEIJI; Shuah Khan
> Subject: Re: [PATCH v2 5/5] selftests/pstore: add testcases for multiple
> pmsg instances
> 
> On Sun, Jul 24, 2016 at 8:56 PM, Nobuhiro Iwamatsu
> <nobuhiro.iwamatsu.kw@...achi.com> wrote:
> > From: Hiraku Toyooka <hiraku.toyooka.gu@...achi.com>
> >
> > To test multiple pmsg, we should check that /dev/pmsg[N] (N > 0) is
> > available. After reboot, we should check that pmsg-[backend]-[N] which
> > keeps content is detected even if pmsg-[backend]-[N-M] (0 < M <= N)
> > doesn't exist due to lack of contents.
> >
> > So this adds the following testcases.
> >  - pstore_tests
> >    - Write unique string to the last /dev/pmsgN
> >  - pstore_post_reboot_tests
> >    - Check the last pmsg area is detected
> >
> > Signed-off-by: Hiraku Toyooka <hiraku.toyooka.gu@...achi.com>
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.kw@...achi.com>
> > Cc: Mark Salyzyn <salyzyn@...roid.com>
> > Cc: Seiji Aguchi <seiji.aguchi.tr@...achi.com>
> > Cc: Shuah Khan <shuahkh@....samsung.com>
> > ---
> >  tools/testing/selftests/pstore/common_tests        | 21
> +++++++++++++++--
> >  .../selftests/pstore/pstore_post_reboot_tests      | 27
> ++++++++++++----------
> >  tools/testing/selftests/pstore/pstore_tests        | 16
> ++++++++++---
> >  3 files changed, 47 insertions(+), 17 deletions(-)
> >
> > diff --git a/tools/testing/selftests/pstore/common_tests
> > b/tools/testing/selftests/pstore/common_tests
> > index 3ea64d7..566a25d 100755
> > --- a/tools/testing/selftests/pstore/common_tests
> > +++ b/tools/testing/selftests/pstore/common_tests

<snip> 

> > +last_devpmsg=`ls -v /dev/pmsg* | tail -n1` prlog -n "Writing unique
> > +string to the last /dev/pmsgN "
> > +if [ "$last_devpmsg" = "/dev/pmsg0" ]; then
> > +    prlog "... No multiple /dev/pmsg* exists. We skip this testcase."
> > +else
> > +    prlog -n "(${last_devpmsg}) ... "
> > +    echo "${TEST_STRING_PATTERN}""$UUID" > ${last_devpmsg}
> > +    show_result $?
> > +
> 
> Blank line here can be dropped.
> 
> > +fi
> > +
> >  exit $rc
> > --
> > 2.8.1
> >
> >
> 
> Otherwise, this looks good. Thanks!
> 

OK, I will fix these.
And thanks again for review this patch series.

> -Kees
> 
> --
> Kees Cook
> Nexus Security


Best regards,
  Nobuhiro