[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <F89ECF87BC754A49BB74E794F6A0EC2FF68246@GSjpTKYDCembx31.service.hitachi.net>
Date: Wed, 5 Oct 2016 04:06:08 +0000
From: 岩松信洋 / IWAMATSU,NOBUHIRO
<nobuhiro.iwamatsu.kw@...achi.com>
To: Kees Cook <keescook@...omium.org>
CC: Anton Vorontsov <anton@...msg.org>,
Colin Cross <ccross@...roid.com>,
"Tony Luck" <tony.luck@...el.com>,
LKML <linux-kernel@...r.kernel.org>,
"Hiraku Toyooka" <hiraku.toyooka.gu@...achi.com>,
Mark Salyzyn <salyzyn@...roid.com>,
阿口誠司 / AGUCHI,SEIJI
<seiji.aguchi.tr@...achi.com>
Subject: RE: Re: [PATCH v2 2/5] ramoops: introduce generic init/free
functions for prz
Hi,
Thanks for youre review.
> -----Original Message-----
> From: keescook@...gle.com [mailto:keescook@...gle.com] On Behalf Of Kees
> Cook
> Sent: Friday, September 09, 2016 6:23 AM
> To: 岩松信洋 / IWAMATSU,NOBUHIRO
> Cc: Anton Vorontsov; Colin Cross; Tony Luck; LKML; Hiraku Toyooka; Mark
> Salyzyn; 阿口誠司 / AGUCHI,SEIJI
> Subject: [!]Re: [PATCH v2 2/5] ramoops: introduce generic init/free
> functions for prz
>
> On Sun, Jul 24, 2016 at 8:56 PM, Nobuhiro Iwamatsu
> <nobuhiro.iwamatsu.kw@...achi.com> wrote:
> > From: Hiraku Toyooka <hiraku.toyooka.gu@...achi.com>
> >
> > We modifies initialization and freeing code for prz for generic usage.
>
> Sorry for the delay in getting to this review, I've been catching up on
> pstore finally. :)
>
> > This change
> >
> > * add generic function __ramoops_init_prz() to reduce redundancy
> > between ramoops_init_prz() and ramoops_init_przs().
>
> Can you split this into a separate patch?
OK, I will do.
>
> > * rename 'przs' member in struct ramoops_context to 'dprzs' so that
> > it stands for 'dump przs'.
> > * rename ramoops_init_prz() to ramoops_init_dprzs().
>
> And also these two into a separate patch, since it's just a renaming.
> And could you add comments for all the przs, it's getting harder to read
> these since they're just single-letter names. :)
>
> > * change parameter of ramoops_free_przs() from struct ramoops_context
> *
> > into struct persistent_ram_zone * in order to make it available for
> > all prz array.
>
> I *think* this should be with the first change, so splitting this email's
> patch into two patches would make review easier (i.e. first do renamings,
> then make functional changes).
OK, I will do too.
>
> > Signed-off-by: Hiraku Toyooka <hiraku.toyooka.gu@...achi.com>
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.kw@...achi.com>
> > Cc: Mark Salyzyn <salyzyn@...roid.com>
> > Cc: Seiji Aguchi <seiji.aguchi.tr@...achi.com>
<snip>
>
> Thanks!
>
> -Kees
>
> --
> Kees Cook
> Nexus Security
Best regards,
Nobuhiro
Powered by blists - more mailing lists