linux-kernel - Re: [PATCH 2/2] Revert "staging: wilc1000: Replace kthread with workqueue for host interface"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Oct 2016 15:26:59 +0530
From:   Aditya Shankar <aditya.shankar@...rochip.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     Aditya Shankar <Aditya.Shankar@...rochip.com>,
        <ganesh.krishna@...rochip.com>, <linux-wireless@...r.kernel.org>,
        <devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>,
        <Nicolas.Ferre@...rochip.com>
Subject: Re: [PATCH 2/2] Revert
 "staging: wilc1000: Replace kthread with workqueue for host interface"

On Fri, 30 Sep 2016 15:22:15 +0200
Greg KH <gregkh@...uxfoundation.org> wrote:

> On Fri, Sep 30, 2016 at 03:43:18PM +0530, Aditya Shankar wrote:
> > This reverts commit 2518ac59eb27 ("staging: wilc1000: Replace kthread
> > with workqueue for host interface")
> > 
> > This commit breaks wilc1000 driver init. A crash was seen
> > everytime the wlan interface was brought up and wilc device
> > open was attempted. This change is being reverted until we
> > figure out the problem in this change. The driver is
> > usable now with this change reverted.
> > 
> > Signed-off-by: Aditya Shankar <Aditya.Shankar@...rochip.com>
> > 
> > Conflicts:
> > 	drivers/staging/wilc1000/host_interface.c
> 
> What is this line doing here?
> 
> And shouldn't we add a cc: stable tag as well?  Or at the least, put a
> "fixes:" tag to let people know exactly what commit it is fixing (the
> id that it is reverting.)
> 
> thanks,
> 
> greg k-h

Apologies for this bad commit message.

I have an update on this wilc1000 crash issue. I've figured out
the cause for the crash and fixed it. Therefore,
I request you to ignore the patch I sent out to
revert the change causing the regression. The cause was a misplaced
call to destroy workqueue soon after creating it.
With this removed, the issue is not seen.

I will send out a separate patch to fix the issue.

Thanks,
Aditya