linux-kernel - Re: [PATCH] spmi: regmap: enable userspace writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c8948deec8547f3615dfaf16e5f7772a@codeaurora.org>
Date:   Thu, 06 Oct 2016 15:40:11 +0530
From:   kgunda@...eaurora.org
To:     Stephen Boyd <sboyd@...eaurora.org>
Cc:     Mark Brown <broonie@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        linux-kernel@...r.kernel.org, aghayal@....qualcomm.com,
        adharmap@...eaurora.org
Subject: Re: [PATCH] spmi: regmap: enable userspace writes

On 2016-10-04 02:33, Stephen Boyd wrote:
> On 09/30, kgunda@...eaurora.org wrote:
>> On 2016-09-29 23:30, Mark Brown wrote:
>> >On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote:
>> >
>> >>-#undef REGMAP_ALLOW_WRITE_DEBUGFS
>> >>+#define REGMAP_ALLOW_WRITE_DEBUGFS
>> >
>> >This is completely inappropriate for upstream, if you need to do
>> >debugging on your platform you can enable this locally but enabling
>> >random writes from userspace to any regmap device is really not a good
>> >idea for system stablity or robustness.
>> 
>> Sure. I will remove this change and send the next version only to 
>> update
>> the spmi device name.
> 
> Why? The device name looks fine.
Ok. I will re-check and ignore the patch, if no changes required.