linux-kernel - Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57F65A73.7020701@codeaurora.org>
Date:   Thu, 6 Oct 2016 09:06:43 -0500
From:   Timur Tabi <timur@...eaurora.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        "David S. Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA

Geert Uytterhoeven wrote:
>   config QCOM_EMAC
>   	tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet support"
> +	depends on HAS_DMA

I think it needs to depend on HAS_IOMEM as well, to fix this error in 
arch/um:

    drivers/net/ethernet/qualcomm/emac/emac.c: In function 'emac_remove':
 >> drivers/net/ethernet/qualcomm/emac/emac.c:727:3: error: implicit 
declaration of function 'iounmap' [-Werror=implicit-function-declaration]
       iounmap(adpt->phy.digital);

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.