linux-kernel - Re: [PATCH] spi: dw: Enable Slave Select with GPIO Chip Select.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2df0001c-dd59-1352-f5be-a22a9798a357@opensource.altera.com>
Date:   Thu, 6 Oct 2016 09:15:02 -0500
From:   Thor Thayer <tthayer@...nsource.altera.com>
To:     Mark Brown <broonie@...nel.org>
CC:     <andriy.shevchenko@...ux.intel.com>,
        <jarkko.nikula@...ux.intel.com>, <jszhang@...vell.com>,
        <michael@...rt-africa.com>, <kernel@...idel.net>,
        <linux-spi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi: dw: Enable Slave Select with GPIO Chip Select.



On 10/06/2016 04:37 AM, Mark Brown wrote:
> On Wed, Oct 05, 2016 at 04:38:58PM -0500, tthayer@...nsource.altera.com wrote:
>
>> This patch adds the Slave Select locally so that the transfer will
>> start and complete. The GPIO CS is taken care of earlier in the SPI
>> framework (spi_set_cs).
>
> This seems like something that other devices might need - it's not the
> first time I heard of a device with the data transfer start and chip
> select being tied together.  Why not make this a generic feature that
> the core implements and drivers can enable?
>
OK. Thanks for the suggestion and review. I'll add a new boolean and 
device tree binding to the SPI core. Thanks.