linux-kernel - Re: [PATCH 06/14] ASoC: Add sun8i digital audio codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20161006182303.sftz3c7hjhv7xell@piout.net>
Date:   Thu, 6 Oct 2016 20:23:03 +0200
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Icenowy Zheng <icenowy@...c.xyz>
Cc:     Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Mylène Josserand 
        <mylene.josserand@...e-electrons.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-sunxi@...glegroups.com" <linux-sunxi@...glegroups.com>,
        "thomas.petazzoni@...e-electrons.com" 
        <thomas.petazzoni@...e-electrons.com>,
        "vinod.koul@...el.com" <vinod.koul@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "sboyd@...eaurora.org" <sboyd@...eaurora.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "perex@...ex.cz" <perex@...ex.cz>, "wens@...e.org" <wens@...e.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 06/14] ASoC: Add sun8i digital audio codec

On 07/10/2016 at 00:06:57 +0800, Icenowy Zheng wrote :
> 05.10.2016, 00:20, "Maxime Ripard" <maxime.ripard@...e-electrons.com>:
> > Hi,
> >
> >>  +static const struct of_device_id sun8i_codec_of_match[] = {
> >>  + { .compatible = "allwinner,sun8i-a33-codec" },
> >>  + { .compatible = "allwinner,sun8i-a23-codec" },
> >
> > I thought that the A23 and A33 had different codecs? In that case, it
> > wouldn't be a good assumption to make
> 
> Yes.
> 
> >
> >>  + {}
> >>  +};
> >>  +MODULE_DEVICE_TABLE(of, sun8i_codec_of_match);
> >>  +
> >>  +static struct platform_driver sun8i_codec_driver = {
> >>  + .driver = {
> >>  + .name = "sun8i-codec",
> >>  + .owner = THIS_MODULE,
> >>  + .of_match_table = sun8i_codec_of_match,
> >>  + },
> >>  + .probe = sun8i_codec_probe,
> >>  + .remove = sun8i_codec_remove,
> >>  +};
> >>  +module_platform_driver(sun8i_codec_driver);
> >>  +
> >>  +MODULE_DESCRIPTION("Allwinner A33 (sun8i) codec driver");
> >>  +MODULE_AUTHOR("huanxin<huanxin@...uimllatech.com>");
> >
> > Those obfuscated email adresses are not really helpful :)
> 
> This kind of email addresses  are kept in many places in mainline kernel.
> 
> e.g. drivers/mmc/host/sunxi-mmc.c have 'Aaron Maoye <leafy.myeh@...uimllatech.com>'
> 

Well, that is only one place and it is a comment, not in the
MODULE_AUTHOR macro. I would agree that it is not useful to have a stale
email address in MODULE_AUTHOR.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com