linux-kernel - Re: [PATCH 3/3] perf, tools: Fix completion script to handle comma list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161006200510.GC4809@kernel.org>
Date:   Thu, 6 Oct 2016 17:05:10 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Andi Kleen <andi@...stfloor.org>
Cc:     jolsa@...nel.org, linux-kernel@...r.kernel.org,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 3/3] perf, tools: Fix completion script to handle comma
 list

Em Thu, Oct 06, 2016 at 12:23:27PM -0700, Andi Kleen escreveu:
> From: Andi Kleen <ak@...ux.intel.com>
> 
> The perf event completion script only handled a single event per
> -e option. So for "perf stat -e cycles,branches" branches could
> not be completed.
> 
> Fix that issue by always only using the last suffix for completion.
> 
> For some reason it only works in bash currently, but zsh
> is the same as before.

It works partially, for instance, if I try completing:

perf stat -e CPL<TAB>

I get:

perf stat -e CPL_CYCLES.RING0

but if I try:

perf stat -e cycles,CPL<TAB>

I get nothing :-\

Is this working with you?
 
> v2: Handle conflict with upper case completion patch
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> ---
>  tools/perf/perf-completion.sh | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh
> index 3b5a258a4b7b..819a1346689f 100644
> --- a/tools/perf/perf-completion.sh
> +++ b/tools/perf/perf-completion.sh
> @@ -166,7 +166,11 @@ __perf_main ()
>  			[[:upper:]]*) evts=$($cmd list --raw-dump json | tr a-z A-Z) ;;
>  			*) evts=$($cmd list --raw-dump) ;;
>  		esac
> +		old="$cur"
> +		cur="${cur/*[,{]/}"
> +		prefix=${old%$cur}
>  		__perfcomp_colon "$evts" "$cur"
> +		COMPREPLY=("${prefix}${COMPREPLY[0]}")
>  	else
>  		# List subcommands for perf commands
>  		if [[ $prev_skip_opts == @(kvm|kmem|mem|lock|sched|
> -- 
> 2.5.5