linux-kernel - RE: [PATCH v7 2/6] mfd: lpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0158A29DB680F54A88142ED28D55B1D0082F77D6@PGSMSX107.gar.corp.intel.com>
Date:   Fri, 7 Oct 2016 07:39:12 +0000
From:   "Tan, Jui Nee" <jui.nee.tan@...el.com>
To:     Lee Jones <lee.jones@...aro.org>
CC:     "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
        "ptyser@...-inc.com" <ptyser@...-inc.com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Yong, Jonathan" <jonathan.yong@...el.com>,
        "Yu, Ong Hock" <ong.hock.yu@...el.com>,
        "Luck, Tony" <tony.luck@...el.com>,
        "Wan Mohamad, Wan Ahmad Zainie" 
        <wan.ahmad.zainie.wan.mohamad@...el.com>
Subject: RE: [PATCH v7 2/6] mfd: lpc_ich: Rename lpc-ich driver



> -----Original Message-----
> From: Lee Jones [mailto:lee.jones@...aro.org]
> Sent: Friday, September 30, 2016 8:31 AM
> To: Tan, Jui Nee <jui.nee.tan@...el.com>
> Cc: mika.westerberg@...ux.intel.com; heikki.krogerus@...ux.intel.com;
> andriy.shevchenko@...ux.intel.com; tglx@...utronix.de; mingo@...hat.com;
> hpa@...or.com; x86@...nel.org; ptyser@...-inc.com;
> linus.walleij@...aro.org; linux-gpio@...r.kernel.org; linux-
> kernel@...r.kernel.org; Yong, Jonathan <jonathan.yong@...el.com>; Yu, Ong
> Hock <ong.hock.yu@...el.com>; Luck, Tony <tony.luck@...el.com>; Wan
> Mohamad, Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@...el.com>
> Subject: Re: [PATCH v7 2/6] mfd: lpc_ich: Rename lpc-ich driver
> 
> On Wed, 28 Sep 2016, Tan Jui Nee wrote:
> 
> > This patch follows the example of mfd/wm831x to rename the driver from
> > "lpc_ich" to "lpc_ich-core".
> >
> > Signed-off-by: Tan Jui Nee <jui.nee.tan@...el.com>
> > ---
> > Changes in V7:
> > 	- No change
> >
> > Changes in V6:
> > 	- none, just a subject line and commit message change.
> >
> >  drivers/mfd/Makefile                      | 1 +
> >  drivers/mfd/{lpc_ich.c => lpc_ich-core.c} | 0
> >  2 files changed, 1 insertion(+)
> >  rename drivers/mfd/{lpc_ich.c => lpc_ich-core.c} (100%)
> >
> > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index
> > 2ba3ba3..260f46f 100644
> > --- a/drivers/mfd/Makefile
> > +++ b/drivers/mfd/Makefile
> > @@ -155,6 +155,7 @@ obj-$(CONFIG_PMIC_ADP5520)	+= adp5520.o
> >  obj-$(CONFIG_MFD_KEMPLD)	+= kempld-core.o
> >  obj-$(CONFIG_MFD_INTEL_QUARK_I2C_GPIO)	+= intel_quark_i2c_gpio.o
> >  obj-$(CONFIG_LPC_SCH)		+= lpc_sch.o
> > +lpc_ich-objs		:= lpc_ich-core.o
> 
> Please use underscores OR obliques, not both.
> 
Noted. I will send out another patch-set with filename lpc_ich_core.
> >  obj-$(CONFIG_LPC_ICH)		+= lpc_ich.o
> >  obj-$(CONFIG_MFD_RDC321X)	+= rdc321x-southbridge.o
> >  obj-$(CONFIG_MFD_JANZ_CMODIO)	+= janz-cmodio.o
> > diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich-core.c
> > similarity index 100% rename from drivers/mfd/lpc_ich.c rename to
> > drivers/mfd/lpc_ich-core.c
> 
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source
> software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog