linux-kernel - Re: [PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA and HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161006.211351.701656198910382646.davem@davemloft.net>
Date:   Thu, 06 Oct 2016 21:13:51 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     geert@...ux-m68k.org
Cc:     timur@...eaurora.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ethernet: qualcomm: QCOM_EMAC should depend on
 HAS_DMA and HAS_IOMEM

From: Geert Uytterhoeven <geert@...ux-m68k.org>
Date: Thu,  6 Oct 2016 16:44:53 +0200

> If NO_DMA=y:
> 
>     drivers/built-in.o: In function `emac_probe':
>     emac.c:(.text+0x3780b8): undefined reference to `bad_dma_ops'
>     emac.c:(.text+0x3780e2): undefined reference to `bad_dma_ops'
>     emac.c:(.text+0x378112): undefined reference to `bad_dma_ops'
>     emac.c:(.text+0x378146): undefined reference to `bad_dma_ops'
>     emac.c:(.text+0x37816e): undefined reference to `bad_dma_ops'
>     drivers/built-in.o:emac.c:(.text+0x37819a): more undefined references to `bad_dma_ops' follow
> 
> If NO_IOMEM=y:
> 
>     drivers/net/ethernet/qualcomm/emac/emac.c: In function ‘emac_remove’:
>     drivers/net/ethernet/qualcomm/emac/emac.c:736:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>        iounmap(adpt->phy.digital);
>        ^
> 
> Add dependencies on HAS_DMA and HAS_IOMEM to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Applied.