linux-kernel - Re: [tip:x86/apic] x86/acpi: Introduce persistent storage for cpuid <-> apicid mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1610071302140.19804@nanos>
Date:   Fri, 7 Oct 2016 13:02:59 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Yinghai Lu <yinghai@...nel.org>
cc:     Dou Liyang <douly.fnst@...fujitsu.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        "linux-tip-commits@...r.kernel.org" 
        <linux-tip-commits@...r.kernel.org>,
        Tony Luck <tony.luck@...el.com>
Subject: Re: [tip:x86/apic] x86/acpi: Introduce persistent storage for cpuid
 <-> apicid mapping

On Thu, 6 Oct 2016, Yinghai Lu wrote:
> On Thu, Oct 6, 2016 at 1:06 AM, Dou Liyang <douly.fnst@...fujitsu.com> wrote:
> Yes, that should work. but should do the same thing for x2apic
> 
> in acpi_parse_x2apic should have
> 
> > +       if (processor->local_apic_id == -1) {
> > +               ++disabled_cpus;
> > +               return -EINVAL;
> > +       }
> 
> that is the reason why i want to extend acpi_register_lapic()
> to take extra disabled_id (one is 0xff and another is 0xffffffff)
> so could save some lines.

That just makes the code harder to follow and is not really worth the
trouble.

Thanks,

	tglx