linux-kernel - Re: [PATCH] tools lib traceevent: Fix kbuffer_read_at

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161007100659.7ac3313e@gandalf.local.home>
Date:   Fri, 7 Oct 2016 10:06:59 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Jiri Olsa <jolsa@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tools lib traceevent: Fix kbuffer_read_at_offset()

On Fri, 7 Oct 2016 13:19:08 +0900
Namhyung Kim <namhyung@...nel.org> wrote:

> Actually kbuffer_load_subbuffer() calls kbuf->next_event().  Inside
> the function it has a loop updating next valid event.  Sometimes, the
> data starts with TIME_EXTEND with value of 0 and the loop skips it
> which ended up setting kbuf->curr to 8. :)

Right, because kbuffer_read_at_offset() should not return a TIME_EXTEND.

-- Steve