linux-kernel - Re: [PATCH] hid-led.c: remove unneccessary underscores

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161007162556.GH30411@mail.corp.redhat.com>
Date:   Fri, 7 Oct 2016 18:25:56 +0200
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Pavel Machek <pavel@....cz>
Cc:     j.anaszewski@...sung.com, linux-leds@...r.kernel.org,
        kernel list <linux-kernel@...r.kernel.org>, jikos@...nel.org,
        linux-input@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH] hid-led.c: remove unneccessary underscores

On Oct 03 2016 or thereabouts, Pavel Machek wrote:
> On Mon 2016-10-03 10:16:26, Pavel Machek wrote:
> > 
> > u8 (and friends) can be used directly in kernel sources (not kernel
> > headers).
> > 
> > Signed-off-by: Pavel Machek <pavel@....cz>
> 
> Zero day bot warned me that this is not quiet correct.
> 
> This would be needed on top. Is there interest in fixed patch?

Having both __ and not __ in the same driver would be a little bit
weird. So I'd say we just continue with the existing code. Thanks for
the submission BTW!

Cheers,
Benjamin

> 
> diff --git a/drivers/hid/hid-led.c b/drivers/hid/hid-led.c
> index cd208ca..be659ca 100644
> --- a/drivers/hid/hid-led.c
> +++ b/drivers/hid/hid-led.c
> @@ -57,8 +57,8 @@ union delcom_packet {
>  		u8 cmd;
>  	} rx;
>  	struct {
> -		le16 family_code;
> -		le16 security_code;
> +		__le16 family_code;
> +		__le16 security_code;
>  		u8 fw_version;
>  	} fw;
>  };
> 
>