linux-kernel - Re: PROBLEM: DWC3 USB 3.0 not working on Odroid-XU4 with Exynos 5422

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 07 Oct 2016 22:26:02 +0200
From:   Michael Niewöhner <linux@...ewoehner.de>
To:     Felipe Balbi <balbi@...nel.org>
Cc:     Vivek Gautam <vivek.gautam@...eaurora.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Pankaj Dubey <pankaj.dubey@...sung.com>,
        Anand Moon <linux.amoon@...il.com>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <k.kozlowski@...sung.com>,
        Linux USB Mailing List <linux-usb@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Vivek Gautam <gautam.vivek@...sung.com>
Subject: Re: PROBLEM: DWC3 USB 3.0 not working on Odroid-XU4 with Exynos
 5422

Hi Felipe,

On Fr, 2016-10-07 at 10:42 +0300, Felipe Balbi wrote:
> Hi,
> 
> Michael Niewöhner <linux@...ewoehner.de> writes:
> > 
> > > 
> > > The clocks are same across working/non-working.
> > > Is it possible to bisect the commit that's causing hang for 4.8x ?
> > 
> > 
> > [c499ff71ff2a281366c6ec7a904c547d806cbcd1] usb: dwc3: core: re-factor init and exit paths
> > This patch causes both the hang on reboot and the lsusb hang.
> 
> How to reproduce? Why don't we see this on x86 and TI boards? I'm
> guessing this is failed bisection, as I can't see anything in that
> commit that would cause reboot hang. Also, that code path is *NOT*
> executed when you run lsusb.
> 

I've tested this procedure multiple times to be sure:

- checkout c499ff71, compile, boot the odroid
- run lsusb -v => lsusb hangs, can't terminate with ctrl-c
- hard reset, after boot run poweroff or reboot => board does not completely power off / reboot (see log below)
- revert c499ff71, mrproper, compile, boot the odroid
- run lsusb -v => shows full output, not hanging
- run reboot or poweroff => board powers off / reboots just fine


dmesg poweroff not working:
...
[  120.733519] systemd-journald[144]: systemd-journald stopped as pid 144       
[  120.742663] systemd-shutdown[1]: Sending SIGKILL to remaining processes...   
[  120.769212] systemd-shutdown[1]: Unmounting file systems.                    
[  120.773713] systemd-shutdown[1]: Unmounting /sys/kernel/debug.               
[  120.827211] systemd-shutdown[1]: Unmounting /dev/mqueue.                     
[  121.081672] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                    
[  121.091687] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                    
[  121.095608] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                    
[  121.101014] systemd-shutdown[1]: All filesystems unmounted.                  
[  121.106523] systemd-shutdown[1]: Deactivating swaps.                         
[  121.111585] systemd-shutdown[1]: All swaps deactivated.                      
[  121.116661] systemd-shutdown[1]: Detaching loop devices.                     
[  121.126395] systemd-shutdown[1]: All loop devices detached.                  
[  121.130525] systemd-shutdown[1]: Detaching DM devices.                       
[  121.135824] systemd-shutdown[1]: All DM devices detached.                    
[  121.166327] systemd-shutdown[1]: /lib/systemd/system-shutdown succeeded.     
[  121.171739] systemd-shutdown[1]: Powering off.

=> at this point removing the sd card would show a message 
"removed mmc0" (not sure what the real message was...) so the board is not completely off.


dmesg poweroff working:
...
[  120.733519] systemd-journald[144]: systemd-journald stopped as pid 144       
[  120.742663] systemd-shutdown[1]: Sending SIGKILL to remaining processes...   
[  120.769212] systemd-shutdown[1]: Unmounting file systems.                    
[  120.773713] systemd-shutdown[1]: Unmounting /sys/kernel/debug.               
[  120.827211] systemd-shutdown[1]: Unmounting /dev/mqueue.                     
[  121.081672] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                    
[  121.091687] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                    
[  121.095608] EXT4-fs (mmcblk1p2): re-mounted. Opts: (null)                    
[  121.101014] systemd-shutdown[1]: All filesystems unmounted.                  
[  121.106523] systemd-shutdown[1]: Deactivating swaps.                         
[  121.111585] systemd-shutdown[1]: All swaps deactivated.                      
[  121.116661] systemd-shutdown[1]: Detaching loop devices.                     
[  121.126395] systemd-shutdown[1]: All loop devices detached.                  
[  121.130525] systemd-shutdown[1]: Detaching DM devices.                       
[  121.135824] systemd-shutdown[1]: All DM devices detached.                    
[  121.166327] systemd-shutdown[1]: /lib/systemd/system-shutdown succeeded.     
[  121.171739] systemd-shutdown[1]: Powering off.
[  121.182331] rebo�



Best regards
Michael