linux-kernel - Re: [PATCH 0/6] Introduce Juniper CBC FPGA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Oct 2016 22:37:39 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pantelis Antoniou <pantelis.antoniou@...sulko.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexandre Courbot <gnurou@...il.com>,
        devel@...verdev.osuosl.org,
        devicetree <devicetree@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        "<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>,
        JawaharBalaji Thirumalaisamy <jawaharb@...iper.net>,
        linux-gpio@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Debjit Ghosh <dghosh@...iper.net>,
        Mohammad Kamil <mkamil@...iper.net>,
        Georgi Vlaev <gvlaev@...iper.net>,
        Frank Rowand <frowand.list@...il.com>,
        Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH 0/6] Introduce Juniper CBC FPGA

On Fri, Oct 07, 2016 at 09:53:29PM +0300, Pantelis Antoniou wrote:
> Hi Greg,
> 
> > On Oct 7, 2016, at 18:39 , Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> > 
> > On Fri, Oct 07, 2016 at 06:20:08PM +0300, Pantelis Antoniou wrote:
> >> Add Juniper's PTX1K CBC FPGA driver. Those FPGAs
> >> are present in Juniper's PTX series of routers.
> >> 
> >> The MFD driver provices a gpio device and a special
> >> driver for Juniper's board infrastucture.
> >> The FPGA infrastucture driver is providing an interface
> >> for user-space handling of the FPGA in those platforms.
> >> 
> >> There are full device tree binding documents for the
> >> master mfd driver and for the slave driver.
> >> 
> >> This patchset is against mainline as of today: v4.8-9431-g3477d16
> >> and is dependent on the "Juniper prerequisites" and
> >> "Juniper infrastructure" patchsets sent earlier.
> >> 
> >> Georgi Vlaev (5):
> >>  mfd: Add support for the PTX1K CBC FPGA
> >>  gpio: Add support for PTX1K CBC FPGA spare GPIOs
> >>  gpio: gpio-cbc: Document bindings of CBC FPGA GPIO block
> >>  gpio: cbc-presence: Add CBC presence detect as GPIO driver
> >>  gpio: gpio-cbc-presense: Document bindings of CBC FPGA presence
> >> 
> >> Tom Kavanagh (1):
> >>  staging: jnx: CBD-FPGA infrastructure
> >> 
> >> .../bindings/gpio/jnx,gpio-cbc-presense.txt        |  31 +
> >> .../devicetree/bindings/gpio/jnx,gpio-cbc.txt      |  30 +
> >> drivers/gpio/Kconfig                               |  23 +
> >> drivers/gpio/Makefile                              |   2 +
> >> drivers/gpio/gpio-cbc-presence.c                   | 460 ++++++++++
> >> drivers/gpio/gpio-cbc.c                            | 236 +++++
> >> drivers/mfd/Kconfig                                |  16 +
> >> drivers/mfd/Makefile                               |   1 +
> >> drivers/mfd/cbc-core.c                             | 971 +++++++++++++++++++++
> >> drivers/staging/jnx/Kconfig                        |  34 +
> >> drivers/staging/jnx/Makefile                       |   5 +
> >> drivers/staging/jnx/jnx-cbc-ptx1k.c                | 242 +++++
> >> drivers/staging/jnx/jnx-cbd-fpga-common.c          | 332 +++++++
> >> drivers/staging/jnx/jnx-cbd-fpga-common.h          |  27 +
> >> drivers/staging/jnx/jnx-cbd-fpga-core.c            | 540 ++++++++++++
> >> drivers/staging/jnx/jnx-cbd-fpga-core.h            |  68 ++
> >> drivers/staging/jnx/jnx-cbd-fpga-platdata.h        |  51 ++
> >> drivers/staging/jnx/jnx-cbd-fpga-ptx1k.c           | 134 +++
> >> drivers/staging/jnx/jnx-cbd-fpga-ptx21k.c          | 143 +++
> >> drivers/staging/jnx/jnx-cbd-fpga-ptx3k.c           | 111 +++
> >> drivers/staging/jnx/jnx-cbd-fpga-ptx5k.c           | 107 +++
> >> include/linux/mfd/cbc-core.h                       | 181 ++++
> >> 22 files changed, 3745 insertions(+)
> > 
> > Please don't mix driver submissions like this.  Staging stuff needs to
> > go to the staging maintainer, gpio to that one, mfd to that one, and so
> > on.
> > 
> > there's almost nothing anyone can do with this series as-is, sorry.
> > 
> > please split it up.
> > 
> 
> Now I’m confused, this is a typical MFD submission:
> 
> https://lwn.net/Articles/587032/
> 
> Looks like it’s normal for a single patchset against multiple subsystems.

Not when it crosses the drivers/staging/ boundry.

> Do we have a definitive form for this?

Either submit all of this stuff "properly", or put it in staging, don't
cross the boundry if at all possible, it just causes a lot of confusion
and headache as the staging stuff could be deleted at any time.

You still haven't explained why you feel drivers/staging/ is the right
place for this codebase.  Again, why not just submit it "properly"?

thanks,

greg k-h