linux-kernel - Re: [PATCH] devicetree: net: micrel-ksz90x1.txt: Properly explain skew settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161006.204923.1914066918563386131.davem@davemloft.net>
Date:   Thu, 06 Oct 2016 20:49:23 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     mike.looijmans@...ic.nl
Cc:     devicetree@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        mark.rutland@....com, andrew@...n.ch, f.fainelli@...il.com
Subject: Re: [PATCH] devicetree: net: micrel-ksz90x1.txt: Properly explain
 skew settings

From: Mike Looijmans <mike.looijmans@...ic.nl>
Date: Wed,  5 Oct 2016 16:03:08 +0200

> The KSZ9031 skew registers contain an offset, the chip's default value
> is "neutral" which does not add any skew. Programming a 0 into a skew
> property will actually set it the maximal negative adjustment and not
> to a neutral position as one would expect.
> 
> Explain this situation in the devicetree binding documentation and list
> the settings that the chip considers neutral.
> 
> Changing the implementation to accept negative values would have been
> a better solution, but would break existing configurations.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@...ic.nl>

Applied.