linux-kernel - Re: [PATCH 2/2] [media] dvb-tc90522: Rename a jump label in tc90522

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57F8DF3C.70208@bfs.de>
Date:   Sat, 08 Oct 2016 13:57:48 +0200
From:   walter harms <wharms@....de>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
CC:     linux-media@...r.kernel.org, Akihiro Tsukada <tskd08@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Michael Ira Krufky <mkrufky@...uxtv.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH 2/2] [media] dvb-tc90522: Rename a jump label in tc90522_probe()



Am 07.10.2016 21:46, schrieb SF Markus Elfring:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 7 Oct 2016 21:13:57 +0200
> 
> Adjust a jump label according to the Linux coding style convention.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/media/dvb-frontends/tc90522.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/dvb-frontends/tc90522.c b/drivers/media/dvb-frontends/tc90522.c
> index c2d45f0..4687e15 100644
> --- a/drivers/media/dvb-frontends/tc90522.c
> +++ b/drivers/media/dvb-frontends/tc90522.c
> @@ -794,14 +794,13 @@ static int tc90522_probe(struct i2c_client *client,
>  	i2c_set_adapdata(adap, state);
>  	ret = i2c_add_adapter(adap);
>  	if (ret < 0)
> -		goto err;
> +		goto free_state;
>  	cfg->tuner_i2c = state->cfg.tuner_i2c = adap;
>  
>  	i2c_set_clientdata(client, &state->cfg);
>  	dev_info(&client->dev, "Toshiba TC90522 attached.\n");
>  	return 0;
> -
> -err:
> +free_state:
>  	kfree(state);
>  	return ret;
>  }

there is only one user, IMHO this can be moved to the if block.

re,
 wh