[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B542F67DF@hasmsx108.ger.corp.intel.com>
Date: Sat, 8 Oct 2016 16:58:28 +0000
From: "Winkler, Tomas" <tomas.winkler@...el.com>
To: Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
CC: "tpmdd-devel@...ts.sourceforge.net"
<tpmdd-devel@...ts.sourceforge.net>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state
> On Sat, Oct 08, 2016 at 07:00:06PM +0300, Jarkko Sakkinen wrote:
>
> > Rather you it would be better not to use cmdReady/goIdle at all if
> > kernel is not compiled with CONFIG_PM.
>
> It would be best practice to ensure the tpm is powered up no matter how the
> kernel is compiled.. The firmware may have left it in idle or something
>
> FWIW, I broadly agree there is no need to put the device into idle on the error
> paths. It probably wasn't idle when the driver attached to it.
Actually, currently it is more common to have the device in the idle state, so in case a driver is not loaded for any reason by the kernel, the platform won't leak power.
Thanks
Tomas
Powered by blists - more mailing lists