linux-kernel - Re: [PATCH] sound: soc: cygnus: add depends on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 8 Oct 2016 13:26:13 -0700
From:   Ray Jui <ray.jui@...adcom.com>
To:     Scott Branden <scott.branden@...adcom.com>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: soc: cygnus: add depends on HAS_DMA

Hi Scott,

On 10/7/2016 12:24 PM, Scott Branden wrote:
> add depends on HAS_DMA to Kconfig.  This fixes error reported
> by kbuild test robot when building for ARCH=m32r:
> ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined!
>
> Signed-off-by: Scott Branden <scott.branden@...adcom.com>
> ---
>   sound/soc/bcm/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/bcm/Kconfig b/sound/soc/bcm/Kconfig
> index d528aac..edf3671 100644
> --- a/sound/soc/bcm/Kconfig
> +++ b/sound/soc/bcm/Kconfig
> @@ -11,6 +11,7 @@ config SND_BCM2835_SOC_I2S
>   config SND_SOC_CYGNUS
>   	tristate "SoC platform audio for Broadcom Cygnus chips"
>   	depends on ARCH_BCM_CYGNUS || COMPILE_TEST
> +	depends on HAS_DMA
>   	help
>   	  Say Y if you want to add support for ASoC audio on Broadcom
>   	  Cygnus chips (bcm958300, bcm958305, bcm911360)
Looks good to me.

Reviewed-by: Ray Jui <ray.jui@...adcom.com>