linux-kernel - Re: [tip:x86/apic] x86/acpi: Introduce persistent storage for cpuid <-> apicid mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <866f5115-f472-d630-d73b-26eba88debad@cn.fujitsu.com>
Date:   Sat, 8 Oct 2016 12:14:11 +0800
From:   Dou Liyang <douly.fnst@...fujitsu.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     Yinghai Lu <yinghai@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        "linux-tip-commits@...r.kernel.org" 
        <linux-tip-commits@...r.kernel.org>,
        Tony Luck <tony.luck@...el.com>
Subject: Re: [tip:x86/apic] x86/acpi: Introduce persistent storage for cpuid
 <-> apicid mapping

Hi tglx,

At 10/07/2016 09:07 PM, Thomas Gleixner wrote:
> On Thu, 6 Oct 2016, Dou Liyang wrote:
>>
>> +       if (processor->id >= 255) {
>> +               ++disabled_cpus;
>
> Incrementing disabled_cpus here is simply wrong because 0xff is an invalid
> local APIC id. So we can simply return -EINVAL and be done with it.
>

Yes, It is.

>> +               return -EINVAL;
>
> Thanks,
>
> 	tglx
>
>

Thanks,

	Dou