linux-kernel - Re: [PATCH 2/3] pinctrl: berlin: Don't leak memory if krealloc() fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2016 10:35:45 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Johannes Thumshirn <jthumshirn@...e.de>
Cc:     "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] pinctrl: berlin: Don't leak memory if krealloc() fails

On Fri, Sep 30, 2016 at 2:13 PM, Johannes Thumshirn <jthumshirn@...e.de> wrote:

> We're directly assigning krealoc()'s return value to pctrl->functions instead
> of using a temporary value to handle error checking. This leaks memory in case
> krealloc() failes. While we're at it, implement error handling for failed
> allocations at all.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>

Patch applied.

Yours,
Linus Walleij