linux-kernel - Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2016 02:03:32 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Zach Brown <zach.brown@...com>
Cc:     mlindner@...vell.com, stephen@...workplumber.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        devel@...verdev.osuosl.org, florian.c.schilhabel@...glemail.com,
        Larry.Finger@...inger.net, gregkh@...uxfoundation.org,
        rpurdie@...ys.net, j.anaszewski@...sung.com,
        linux-leds@...r.kernel.org, Andrew Lunn <andrew@...n.ch>
Subject: Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link
 state change

On 10/07/2016 02:14 PM, Zach Brown wrote:
> From: Josh Cartwright <josh.cartwright@...com>
> 
> Create an option CONFIG_LED_TRIGGER_PHY (default n), which will
> create a set of led triggers for each instantiated PHY device.  There is
> one LED trigger per link-speed, per-phy.
> 
> This allows for a user to configure their system to allow a set of LEDs
> to represent link state changes on the phy.

Seems like we are past the RFC state now, so you might want to prefix
your patches with [PATCH ..] now. Also, the typical prefix used for
PHYLIB changes is net: phy: foo

Other than that:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Andrew, are you happy with this implementation?

[snip]

> +
> +#ifdef CONFIG_LED_TRIGGER_PHY
> +
> +#include <linux/leds.h>
> +#include <linux/phy.h>
> +
> +#define PHY_LINK_LED_MAX_TRIGGERS	5
> +#define PHY_LED_TRIGGER_SPEED_SUFFIX_SIZE	7
> +#define PHY_MII_BUS_ID_SIZE	(20 - 3)

This particular constant may be something worth moving to
include/linux/phy.h eventually.
-- 
Florian