lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Oct 2016 10:15:41 +0100 From: Russell King - ARM Linux <linux@...linux.org.uk> To: Finn Thain <fthain@...egraphics.com.au> Cc: "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, linux-arm-kernel@...ts.infradead.org, Michael Schmitz <schmitzmic@...il.com>, Ondrej Zary <linux@...nbow-software.org>, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 11/12] scsi/ncr5380: Use correct types for DMA routines On Mon, Oct 10, 2016 at 12:46:53AM -0400, Finn Thain wrote: > Apply prototypes to get consistent function signatures for the DMA > functions implemented in the board-specific drivers. To avoid using > macros to alter actual parameters, some of those functions are reworked > slightly. > > This is a step toward the goal of passing the board-specific routines > to the core driver using an ops struct (as in a platform driver or > library module). > > This also helps fix some inconsistent types: where the core driver uses > ints (cmd->SCp.this_residual and hostdata->dma_len) for keeping track of > transfers, certain board-specific routines used unsigned long. > > While we are fixing these function signatures, pass the hostdata pointer > to DMA routines instead of a Scsi_Host pointer, for shorter and faster > code. > > Signed-off-by: Finn Thain <fthain@...egraphics.com.au> > Reviewed-by: Hannes Reinecke <hare@...e.com> > Tested-by: Ondrej Zary <linux@...nbow-software.org> > Tested-by: Michael Schmitz <schmitzmic@...il.com> > --- > drivers/scsi/arm/cumana_1.c | 26 ++++++++++------ > drivers/scsi/arm/oak.c | 13 ++++---- For these two, Acked-by: Russell King <rmk+kernel@...linux.org.uk> Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
Powered by blists - more mailing lists