linux-kernel - [PATCH] dmaengine: mmp_tdma: select GENERIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2016 14:07:35 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Vinod Koul <vinod.koul@...el.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Dan Williams <dan.j.williams@...el.com>,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] dmaengine: mmp_tdma: select GENERIC_ALLOCATOR

build testing on x86 revealed a missing dependency that leads to a link error:

drivers/dma/built-in.o: In function `mmp_tdma_prep_dma_cyclic':
mmp_tdma.c:(.text+0x9564): undefined reference to `gen_pool_dma_alloc'
drivers/dma/built-in.o: In function `mmp_tdma_free_chan_resources':
mmp_tdma.c:(.text+0x9675): undefined reference to `gen_pool_free'
drivers/dma/built-in.o: In function `mmp_tdma_probe':
mmp_tdma.c:(.text+0x9854): undefined reference to `of_gen_pool_get'

This adds a 'select' statement to the driver to get it to build cleanly.

Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/dma/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index af63a6bcf564..d882eb0fa551 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -305,6 +305,7 @@ config MMP_TDMA
 	bool "MMP Two-Channel DMA support"
 	depends on ARCH_MMP || COMPILE_TEST
 	select DMA_ENGINE
+	select GENERIC_ALLOCATOR
 	select MMP_SRAM if ARCH_MMP
 	help
 	  Support the MMP Two-Channel DMA engine.
-- 
2.9.0