linux-kernel - Re: [PATCH] drivers: staging: greybus: audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2016 17:25:05 +0530
From:   Vaibhav Agarwal <vaibhav.sr@...il.com>
To:     Chase Metzger <chasemetzger15@...il.com>
Cc:     Mark Greer <mgreer@...malcreek.com>,
        Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: greybus: audio_codec.c: Fixed CHECKS
 for brace issues

On Mon, Oct 10, 2016 at 3:56 AM, Chase Metzger <chasemetzger15@...il.com> wrote:
> Added braces to else statement where checkpatch complained.
>
> Signed-off-by: Chase Metzger <chasemetzger15@...il.com>
> ---
>  drivers/staging/greybus/audio_codec.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index 8a0744b..1bdf849 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -655,8 +655,10 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
>                         ret = gb_audio_apbridgea_shutdown_rx(data->connection,
>                                                              0);
>                 params->state = GBAUDIO_CODEC_STOP;
> -       } else
> +       } else {
>                 ret = -EINVAL;
> +       }
> +
>         if (ret)
>                 dev_err_ratelimited(dai->dev,
>                                     "%s:Error during %s %s stream:%d\n",
> --
> 2.1.4
>
Reviewed-by: Vaibhav Agarwal <vaibhav.sr@...il.com>