linux-kernel - Re: [RFC][PATCHv2 4/7] printk: make alt_printk available when config printk set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 8 Oct 2016 04:08:29 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Jan Kara <jack@...e.cz>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Tejun Heo <tj@...nel.org>, Calvin Owens <calvinowens@...com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Subject: Re: [RFC][PATCHv2 4/7] printk: make alt_printk available when config
 printk set

On (10/06/16 17:23), Petr Mladek wrote:
> This line should be added already in the 3rd patch.
[..]
> Also the initialization of both irq works should be done already
> in the 3rd patch.

indeed. my bad. thanks.

> BTW: I have tried to simulate the compilation on an architecture
> without NMI (commented out HAVE_NMI in arch/x86/Kconfig
> and I have got the following build error with the first three
> patches only:
> 
>   LD      init/built-in.o
> kernel/built-in.o: In function `vprintk':
> /prace/kernel/linux/kernel/printk/printk.c:1914: undefined reference to `vprintk_func'
> kernel/built-in.o: In function `printk':
> /prace/kernel/linux/kernel/printk/printk.c:1976: undefined reference to `vprintk_func'
> Makefile:949: recipe for target 'vmlinux' failed

Fengguang Wu reported a build error for V1 on some .configs, I thought it
was fixed in V2.

thanks a lot!

	-ss

> Where the two lines are in:
> 
> asmlinkage int vprintk(const char *fmt, va_list args)
> {
> 	return vprintk_func(fmt, args);
> }
> 
> and
> 
> asmlinkage __visible int printk(const char *fmt, ...)
> {
> 	va_list args;
> 	int r;
> 
> 	va_start(args, fmt);
> 	r = vprintk_func(fmt, args);
> 	va_end(args);
> 
> 	return r;
> }
> 
> 
> I know that it is a pain to make it all correctly. I suffered from headaches
> when preparing the WARN_*DEFERRED() patchset :-)