[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 10 Oct 2016 09:11:25 -0400
From: Jes Sorensen <Jes.Sorensen@...hat.com>
To: SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc: Jiri Kosina <jikos@...nel.org>,
"Austin S. Hemmelgarn" <ahferroin7@...il.com>,
Dan Carpenter <dan.carpenter@...cle.com>,
Richard Weinberger <richard@....at>,
linux-raid@...r.kernel.org, Christoph Hellwig <hch@....de>,
Guoqing Jiang <gqjiang@...e.com>, Jens Axboe <axboe@...com>,
Mike Christie <mchristi@...hat.com>,
Neil Brown <neilb@...e.com>, Shaohua Li <shli@...nel.org>,
Tomasz Majchrzak <tomasz.majchrzak@...el.com>,
LKML <linux-kernel@...r.kernel.org>,
kernel-janitors@...r.kernel.org,
Julia Lawall <julia.lawall@...6.fr>
Subject: Re: md/raid1: Improve another size determination in setup_conf()
SF Markus Elfring <elfring@...rs.sourceforge.net> writes:
>>>> but patches that just fix coding style are a bad thing
>>>
>>> When you find such a change opportunity so "bad", are there any
>>> circumstances left over where you would dare to touch the corresponding
>>> source code line.
>>
>> If you actually rewrite the code or fix some real bug there.
>
> Do the proposed update steps 12 - 16 for the function "setup_conf"
> (in this software module) fit to your condition?
>
> Do you reject this update step?
I do - those changes do nothing to improve the code and simply hides a
lot of history.
Jes
Powered by blists - more mailing lists