linux-kernel - Re: [PATCH v3 04/18] x86/intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2016 09:01:44 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Nilay Vaish <nilayvaish@...il.com>,
        Fenghua Yu <fenghua.yu@...el.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        "H. Peter Anvin" <h.peter.anvin@...el.com>,
        Ingo Molnar <mingo@...e.hu>, Tony Luck <tony.luck@...el.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Stephane Eranian <eranian@...gle.com>,
        Borislav Petkov <bp@...e.de>, Shaohua Li <shli@...com>,
        David Carrillo-Cisneros <davidcc@...gle.com>,
        Ravi V Shankar <ravi.v.shankar@...el.com>,
        Sai Prakhya <sai.praneeth.prakhya@...el.com>,
        Vikas Shivappa <vikas.shivappa@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>, x86 <x86@...nel.org>
Subject: Re: [PATCH v3 04/18] x86/intel_rdt: Feature discovery

On 10/08/2016 10:11 AM, Nilay Vaish wrote:
>> >  #define X86_FEATURE_RTM                ( 9*32+11) /* Restricted Transactional Memory */
>> >  #define X86_FEATURE_CQM                ( 9*32+12) /* Cache QoS Monitoring */
>> >  #define X86_FEATURE_MPX                ( 9*32+14) /* Memory Protection Extension */
>> > +#define X86_FEATURE_RDT_A      ( 9*32+15) /* Resource Director Technology Allocation */
>> >  #define X86_FEATURE_AVX512F    ( 9*32+16) /* AVX-512 Foundation */
>> >  #define X86_FEATURE_AVX512DQ   ( 9*32+17) /* AVX-512 DQ (Double/Quad granular) Instructions */
>> >  #define X86_FEATURE_RDSEED     ( 9*32+18) /* The RDSEED instruction */
> I think these #defines are specific to Intel.  I would prefer if we
> have _INTEL_ somewhere in them.

While that isn't a horrible idea, it's also not something that we've
enforced at *all* in the past.  Would you suggest that we do this only
for features in the generic CPUID leaves, or all features?