lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Oct 2016 13:59:26 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Chris Packham <Chris.Packham@...iedtelesis.co.nz> Cc: "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>, Masahiko Iwamoto <iwamoto@...ied-telesis.co.jp>, Joshua Scott <Joshua.Scott@...iedtelesis.co.nz>, Kevin Tsai <ktsai@...ellamicro.com>, Wolfram Sang <wsa@...-dreams.de>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Jean Delvare <jdelvare@...e.com>, Jonathan Corbet <corbet@....net>, "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org> Subject: Re: [PATCHv3] hwmon: Add tc654 driver On Mon, Oct 10, 2016 at 08:08:14PM +0000, Chris Packham wrote: > On 10/11/2016 02:22 AM, Guenter Roeck wrote: > >> + if (val) > >> > + data->config |= TC654_REG_CONFIG_DUTYC; > >> > + else > >> > + data->config &= ~TC654_REG_CONFIG_DUTYC; > > I just realized that this won't work as intended. Problem is that you > > only fill data->config when reading an attribute. So, if a set function > > is called prior to reading an attribute, data->config will be 0, and > > you end up overwriting the original configuration. > > > > Should I just read it in the probe function or fill it in with the > documented hardware defaults? Reading it would be better - that leaves the option open that it was configured by ROMMON or BIOS. Guenter
Powered by blists - more mailing lists