linux-kernel - Re: [PATCH 3/7] pstore: Remove case of PSTORE_TYPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2016 16:52:43 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Joel Fernandes <joelaf@...gle.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH 3/7] pstore: Remove case of PSTORE_TYPE_PMSG write using
 deprecated function

On Fri, Oct 7, 2016 at 10:28 PM, Joel Fernandes <joelaf@...gle.com> wrote:
> PMSG now uses ramoops_pstore_write_buf_user instead of ramoops_pstore_write_buf
> Remove the case where we check PSTORE_TYPE_PMSG case.

Ah yeah, good point. Can you actually improve this to add a
ratelimited WARN() to both _write_buf and write_buf_user when an
unhandled type is encountered?

-Kees

>
> Signed-off-by: Joel Fernandes <joelaf@...gle.com>
> ---
>  fs/pstore/ram.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 751197d..519404c 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -287,11 +287,6 @@ static int notrace ramoops_pstore_write_buf(enum pstore_type_id type,
>                         return -ENOMEM;
>                 persistent_ram_write(cxt->fprz, buf, size, 1);
>                 return 0;
> -       } else if (type == PSTORE_TYPE_PMSG) {
> -               if (!cxt->mprz)
> -                       return -ENOMEM;
> -               persistent_ram_write(cxt->mprz, buf, size, 1);
> -               return 0;
>         }
>
>         if (type != PSTORE_TYPE_DMESG)
> --
> 2.7.4
>



-- 
Kees Cook
Nexus Security