linux-kernel - Re: [PATCH V2] staging: ks7010: use netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2016 07:43:09 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Sabitha George <sabitha.george@...il.com>,
        wsa+renesas@...g-engineering.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] staging: ks7010: use netdev_* instead of printk()

On Sun, Oct 09, 2016 at 10:46:26AM -0700, Joe Perches wrote:
> On Sun, 2016-10-09 at 22:04 +0530, Sabitha George wrote:
> > Fixes checkpatch warning on printk usage in ks_hostif.c
> []
> > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> []
> > @@ -465,8 +465,7 @@ void hostif_data_indication(struct ks_wlan_private *priv)
> >  			skb->dev->last_rx = jiffies;
> >  			netif_rx(skb);
> >  		} else {
> > -			printk(KERN_WARNING
> > -			       "ks_wlan: Memory squeeze, dropping packet.\n");
> > +			netdev_warn(priv->net_dev, "ks_wlan: Memory squeeze, dropping packet.\n");
> 
> You could probably drop all the "ks_wlan: " prefixes here
> and the rx_dropped increase generally removes the need
> for a non-rate-limited warning message so these
> memory squeeze messages could be removed as well.

I agree, ks_wlan: should be removed.

thanks,

greg k-h