linux-kernel - RE: [PATCH]"drm: change DRM_MIPI_DSI module type from "bool" to "tristate".

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Oct 2016 12:33:32 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     "Sun\, Jing A" <jing.a.sun@...el.com>, Takashi Iwai <tiwai@...e.de>
Cc:     "airlied\@linux.ie" <airlied@...ux.ie>,
        "Vetter\, Daniel" <daniel.vetter@...el.com>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel\@lists.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "a.hajda\@samsung.com" <a.hajda@...sung.com>,
        Thierry Reding <treding@...dia.com>,
        Emil Velikov <emil.l.velikov@...il.com>
Subject: RE: [PATCH]"drm: change DRM_MIPI_DSI module type from "bool" to "tristate".

On Tue, 11 Oct 2016, "Sun, Jing A" <jing.a.sun@...el.com> wrote:
> It's needed that DRM Driver module could be removed and reloaded after
> kernel booting on the projects that I have been working on, and I hope
> such module type change could be accepted. Looks like Iwai has similar
> change request as well. Would you please review it and let us know if
> any concerns?

Looking at the Kconfig, selecting CONFIG_DRM_MIPI_DSI is against the
recommendations of Documentation/kbuild/kconfig-language.txt:

	select should be used with care. select will force
	a symbol to a value without visiting the dependencies.
	By abusing select you are able to select a symbol FOO even
	if FOO depends on BAR that is not set.
	In general use select only for non-visible symbols
	(no prompts anywhere) and for symbols with no dependencies.
	That will limit the usefulness but on the other hand avoid
	the illegal configurations all over.

Indeed, you may end up with CONFIG_DRM_MIPI_DSI=y and CONFIG_DRM=m,
which violates DRM_MIPI_DSI dependency on CONFIG_DRM. This is broken and
should be fixed. The suggested patch does *not* fix this issue.

Interestingly, I am able to reload i915 and drm. Our CI has tests for
i915 unload/reload, but does not check drm. In any case the config
problem should not impact the reloadability of i915.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center