linux-kernel - Re: [RESEND PATCH v6, 4/5] usb: Add MediaTek USB3 DRD Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48357a7f-deee-b114-ccd4-914fd5fa400f@gmail.com>
Date:   Tue, 11 Oct 2016 12:23:55 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Oliver Neukum <oneukum@...e.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Ian Campbell <ijc+devicetree@...lion.org.uk>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Pawel Moll <pawel.moll@....com>,
        Kumar Gala <galak@...eaurora.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Alan Cooper <alcooperx@...il.com>, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [RESEND PATCH v6, 4/5] usb: Add MediaTek USB3 DRD Driver



On 10/11/2016 05:14 AM, Chunfeng Yun wrote:
> On Mon, 2016-10-10 at 13:00 +0200, Matthias Brugger wrote:
>>
>> On 09/21/2016 07:54 AM, Chunfeng Yun wrote:
>>> This patch adds support for the MediaTek USB3 controller
>>> integrated into MT8173. It can be configured as Dual-Role
>>> Device (DRD), Peripheral Only and Host Only (xHCI) modes.
>>>
>>> Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>
>>> ---
>>>  drivers/usb/Kconfig                |    2 +
>>>  drivers/usb/Makefile               |    1 +
>>>  drivers/usb/mtu3/Kconfig           |   54 +++
>>>  drivers/usb/mtu3/Makefile          |   19 +
>>>  drivers/usb/mtu3/mtu3.h            |  422 +++++++++++++++++
>>>  drivers/usb/mtu3/mtu3_core.c       |  871 +++++++++++++++++++++++++++++++++++
>>>  drivers/usb/mtu3/mtu3_dr.c         |  379 ++++++++++++++++
>>>  drivers/usb/mtu3/mtu3_dr.h         |  108 +++++
>>>  drivers/usb/mtu3/mtu3_gadget.c     |  731 +++++++++++++++++++++++++++++
>>>  drivers/usb/mtu3/mtu3_gadget_ep0.c |  883 ++++++++++++++++++++++++++++++++++++
>>>  drivers/usb/mtu3/mtu3_host.c       |  294 ++++++++++++
>>>  drivers/usb/mtu3/mtu3_hw_regs.h    |  473 +++++++++++++++++++
>>>  drivers/usb/mtu3/mtu3_plat.c       |  490 ++++++++++++++++++++
>>>  drivers/usb/mtu3/mtu3_qmu.c        |  599 ++++++++++++++++++++++++
>>>  drivers/usb/mtu3/mtu3_qmu.h        |   43 ++
>>>  15 files changed, 5369 insertions(+)
>>>  create mode 100644 drivers/usb/mtu3/Kconfig
>>>  create mode 100644 drivers/usb/mtu3/Makefile
>>>  create mode 100644 drivers/usb/mtu3/mtu3.h
>>>  create mode 100644 drivers/usb/mtu3/mtu3_core.c
>>>  create mode 100644 drivers/usb/mtu3/mtu3_dr.c
>>>  create mode 100644 drivers/usb/mtu3/mtu3_dr.h
>>>  create mode 100644 drivers/usb/mtu3/mtu3_gadget.c
>>>  create mode 100644 drivers/usb/mtu3/mtu3_gadget_ep0.c
>>>  create mode 100644 drivers/usb/mtu3/mtu3_host.c
>>>  create mode 100644 drivers/usb/mtu3/mtu3_hw_regs.h
>>>  create mode 100644 drivers/usb/mtu3/mtu3_plat.c
>>>  create mode 100644 drivers/usb/mtu3/mtu3_qmu.c
>>>  create mode 100644 drivers/usb/mtu3/mtu3_qmu.h
>>>
>>
>> As Oliver already said, this patch is quiet big which makes it difficult
>> to review.
>> I propose to provide a first implementation with minimal functionality
>> and incremental patches on top of this when the first got merged.
>>
>> You could split the patch in three series/parts:
>> 1. Host only
>> 2. Peripheral only
>> 3. Dual mode
>>
>> What do you think?
>
> Ok, I'll split the patch into some small ones as many as possible.

There is no direct policy how to do that and it depends a bit on every 
maintainer what he prefers. As a rule of thumb each commit should 
compile on it's own without errors. This makes bisecting the kernel much 
easier.

Regards,
Matthias

>
> Thanks a lot
>>
>> Regards,
>> Matthias
>>
>
>