linux-kernel - Re: [PATCH v3] xenbus: advertize control feature flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e41659c8-2718-823f-3159-1a2396138010@citrix.com>
Date:   Tue, 11 Oct 2016 12:25:57 +0100
From:   David Vrabel <david.vrabel@...rix.com>
To:     Juergen Gross <jgross@...e.com>,
        Paul Durrant <paul.durrant@...rix.com>,
        <xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>
CC:     Boris Ostrovsky <boris.ostrovsky@...cle.com>
Subject: Re: [PATCH v3] xenbus: advertize control feature flags

On 11/10/16 11:53, Juergen Gross wrote:
> On 10/10/16 12:13, Paul Durrant wrote:
>> The Xen docs specify several flags which a guest can set to advertize
>> which values of the xenstore control/shutdown key it will recognize.
>> This patch adds code to write all the relevant feature-flag keys.
>>
>> Signed-off-by: Paul Durrant <paul.durrant@...rix.com>
>> Cc: Boris Ostrovsky <boris.ostrovsky@...cle.com>
>> Cc: David Vrabel <david.vrabel@...rix.com>
>> Cc: Juergen Gross <jgross@...e.com>
> 
> Hmm, I'd prefer node[] allocated on the stack over dynamic allocation.
> 
> What about something like the following? It will at least issue build
> warnings in case the size is too small, will use less memory and less
> coding.

You still want snprintf() just to be sure.  You can add a Reviewed-by
David Vrabel <david.vrabel@...rix.com> if you make this change.

David