linux-kernel - Re: [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161011141407.3b233e83@xeon-e3>
Date:   Tue, 11 Oct 2016 14:14:07 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Zach Brown <zach.brown@...com>
Cc:     f.fainelli@...il.com, mlindner@...vell.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        florian.c.schilhabel@...glemail.com, Larry.Finger@...inger.net,
        gregkh@...uxfoundation.org, rpurdie@...ys.net,
        j.anaszewski@...sung.com, linux-leds@...r.kernel.org,
        andrew@...n.ch
Subject: Re: [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge
 driver to avoid conflicts with leds namespace

On Tue, 11 Oct 2016 15:26:18 -0500
Zach Brown <zach.brown@...com> wrote:

> Adding led support for phy causes namespace conflicts for some
> phy drivers.
> 
> The marvel skge driver declared an enum for representing the states of
> Link LED Register. The enum contained constant LED_OFF which conflicted
> with declartation found in linux/leds.h.
> LED_OFF changed to LED_REG_OFF
> Also changed LED_ON to LED_REG_ON to avoid possible future conflict and
> for consistency.
> 
> Signed-off-by: Zach Brown <zach.brown@...com>

Sure, that's fine but not sure why skge would be including linux/leds.h
anyway.