linux-kernel - Re: [PATCH v8 4/6] mfd: move enum lpc_chipsets into lpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1476267889.11323.446.camel@linux.intel.com>
Date:   Wed, 12 Oct 2016 13:24:49 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Tan Jui Nee <jui.nee.tan@...el.com>,
        mika.westerberg@...ux.intel.com, heikki.krogerus@...ux.intel.com,
        tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, ptyser@...-inc.com, lee.jones@...aro.org,
        linus.walleij@...aro.org
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        jonathan.yong@...el.com, ong.hock.yu@...el.com,
        tony.luck@...el.com, wan.ahmad.zainie.wan.mohamad@...el.com
Subject: Re: [PATCH v8 4/6] mfd: move enum lpc_chipsets into lpc_ich.h

On Wed, 2016-10-12 at 14:51 +0800, Tan Jui Nee wrote:
> Move the enum's definition into a standalone header file which can be
> used
> wherever its definition is needed.
> 
> --- a/include/linux/mfd/lpc_ich.h
> +++ b/include/linux/mfd/lpc_ich.h
> @@ -43,4 +43,75 @@ struct lpc_ich_info {
>  	u8 use_gpio;
>  };
>  
> +/* chipset related info */
> +enum lpc_chipsets {

Maybe it worth to add that the list should be not shuffled, new items
should go at the end.

But it is up to you.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy