linux-kernel - Re: [PATCH] mm: kmemleak: Ensure that the task stack is not freed during scanning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161012104758.GB21592@e104818-lin.cambridge.arm.com>
Date:   Wed, 12 Oct 2016 11:47:58 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Hillf Danton <hillf.zj@...baba-inc.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        'Andrew Morton' <akpm@...ux-foundation.org>,
        'Andy Lutomirski' <luto@...nel.org>,
        'CAI Qian' <caiqian@...hat.com>
Subject: Re: [PATCH] mm: kmemleak: Ensure that the task stack is not freed
 during scanning

On Wed, Oct 12, 2016 at 06:16:46PM +0800, Hillf Danton wrote:
> > @@ -1453,8 +1453,11 @@ static void kmemleak_scan(void)
> > 
> >  		read_lock(&tasklist_lock);
> >  		do_each_thread(g, p) {
> 
> Take a look at this commit please.
> 	1da4db0cd5 ("oom_kill: change oom_kill.c to use for_each_thread()")

Thanks. Isn't holding tasklist_lock here enough to avoid such races?

-- 
Catalin