linux-kernel - [PATCH 3.4 014/125] HID: core: Avoid uninitialized buffer access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1476275641-4697-14-git-send-email-lizf@kernel.org>
Date:   Wed, 12 Oct 2016 20:32:10 +0800
From:   lizf@...nel.org
To:     stable@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Richard Purdie <richard.purdie@...uxfoundation.org>,
        Jiri Kosina <jikos@...nel.org>, linux-input@...r.kernel.org,
        Darren Hart <dvhart@...ux.intel.com>,
        Jiri Kosina <jkosina@...e.cz>, Zefan Li <lizefan@...wei.com>
Subject: [PATCH 3.4 014/125] HID: core: Avoid uninitialized buffer access

From: Richard Purdie <richard.purdie@...uxfoundation.org>

3.4.113-rc1 review patch.  If anyone has any objections, please let me know.

------------------


commit 79b568b9d0c7c5d81932f4486d50b38efdd6da6d upstream.

hid_connect adds various strings to the buffer but they're all
conditional. You can find circumstances where nothing would be written
to it but the kernel will still print the supposedly empty buffer with
printk. This leads to corruption on the console/in the logs.

Ensure buf is initialized to an empty string.

Signed-off-by: Richard Purdie <richard.purdie@...uxfoundation.org>
[dvhart: Initialize string to "" rather than assign buf[0] = NULL;]
Cc: Jiri Kosina <jikos@...nel.org>
Cc: linux-input@...r.kernel.org
Signed-off-by: Darren Hart <dvhart@...ux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@...e.cz>
Signed-off-by: Zefan Li <lizefan@...wei.com>
---
 drivers/hid/hid-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 75fa2e7..b8ad132 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1301,7 +1301,7 @@ int hid_connect(struct hid_device *hdev, unsigned int connect_mask)
 		"Multi-Axis Controller"
 	};
 	const char *type, *bus;
-	char buf[64];
+	char buf[64] = "";
 	unsigned int i;
 	int len;
 	int ret;
-- 
1.9.1