linux-kernel - Re: [PATCH 3.4 027/125] firewire: ohci: fix JMicron JMB38x IT context discovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161012150821.7f8bda8c@kant>
Date:   Wed, 12 Oct 2016 15:08:21 +0200
From:   Stefan Richter <stefanr@...6.in-berlin.de>
To:     lizf@...nel.org
Cc:     stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zefan Li <lizefan@...wei.com>
Subject: Re: [PATCH 3.4 027/125] firewire: ohci: fix JMicron JMB38x IT
 context discovery

On Oct 12 lizf@...nel.org wrote:
[...]
> Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de>
> [lizf: Backported to 3.4: use dev_notice() instead of ohci_notice()]
> Signed-off-by: Zefan Li <lizefan@...wei.com>
> ---
>  drivers/firewire/ohci.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c
> index c1de4c3..4eedb07 100644
> --- a/drivers/firewire/ohci.c
> +++ b/drivers/firewire/ohci.c
> @@ -3620,6 +3620,11 @@ static int __devinit pci_probe(struct pci_dev *dev,
>  
>  	reg_write(ohci, OHCI1394_IsoXmitIntMaskSet, ~0);
>  	ohci->it_context_support = reg_read(ohci, OHCI1394_IsoXmitIntMaskSet);
> +	/* JMicron JMB38x often shows 0 at first read, just ignore it */
> +	if (!ohci->it_context_support) {
> +		dev_notice(&dev->dev, "overriding IsoXmitIntMask\n");
> +		ohci->it_context_support = 0xf;
> +	}
>  	reg_write(ohci, OHCI1394_IsoXmitIntMaskClear, ~0);
>  	ohci->it_context_mask = ohci->it_context_support;
>  	ohci->n_it = hweight32(ohci->it_context_mask);

Backport looks good to me.  Thanks.
-- 
Stefan Richter
-======----- =-=- -==--
http://arcgraph.de/sr/