linux-kernel - Re: [PATCH v3 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161012053842.GF19385@vireshk-i7>
Date:   Wed, 12 Oct 2016 11:08:42 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Markus Mayer <mmayer@...adcom.com>
Cc:     "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Broadcom Kernel List <bcm-kernel-feedback-list@...adcom.com>,
        Device Tree List <devicetree@...r.kernel.org>,
        Power Management List <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver
 for Broadcom STB SoCs

On 07-10-16, 16:21, Markus Mayer wrote:
> +static int brcm_avs_cpufreq_exit(struct cpufreq_policy *policy)
> +{
> +	struct private_data *priv = policy->driver_data;
> +
> +	iounmap(priv->base);
> +	iounmap(priv->avs_intr_base);
> +
> +	return 0;
> +}

Shouldn't the above be done in the below routine instead ?

> +static int brcm_avs_cpufreq_remove(struct platform_device *pdev)
> +{
> +	platform_set_drvdata(pdev, NULL);
> +
> +	return cpufreq_unregister_driver(&brcm_avs_driver);
> +}

-- 
viresh