linux-kernel - Re: [PATCH] gpio / ACPI: fix returned error from acpi_dev_gpio_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN+gG=GUJ-VW7y1HMO+txdF8KpyaS6as3na=-FbAOUVBEkS=kA@mail.gmail.com>
Date:   Wed, 12 Oct 2016 18:47:04 +0200
From:   Benjamin Tissoires <benjamin.tissoires@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Alexandre Courbot <gnurou@...il.com>,
        Mika Westerberg <mika.westerberg@...el.com>
Cc:     David Arcari <darcari@...hat.com>, linux-gpio@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>
Subject: Re: [PATCH] gpio / ACPI: fix returned error from acpi_dev_gpio_irq_get()

On Wed, Oct 12, 2016 at 6:40 PM, Benjamin Tissoires
<benjamin.tissoires@...hat.com> wrote:
> From: David Arcari <darcari@...hat.com>
>
> acpi_dev_gpio_irq_get() currently ignores the error returned
> by acpi_get_gpiod_by_index() and overwrites it with -ENOENT.
>
> Problem is this error can be -EPROBE_DEFER, which just blows
> up some drivers when the module ordering is not correct.
>
> Cc: stable@...r.kernel.org
> Signed-off-by: David Arcari <darcari@...hat.com>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> ---
>
> Hi David,
>
> I am planning on sending this to the list, any last minute comments?

Of course, I forgot to remove our internal sync comment.
David's answer was "No.  This looks good to me.", so I just went ahead
and send the patch.

Cheers,
Benjamin