linux-kernel - Re: [patch] drm/amdgpu: potential NULL dereference in debugfs code

Open Source and information security mailing list archives

Message-ID: <CADnq5_PX+E0WO5ACAd31P3PJiSfc8EvLW21_bdvrP0ivURj9Dw@mail.gmail.com>
Date:   Wed, 12 Oct 2016 12:48:20 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Christian König <christian.koenig@....com>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Alex Deucher <alexander.deucher@....com>,
        Tom St Denis <tom.stdenis@....com>,
        Jammy Zhou <Jammy.Zhou@....com>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        Junwei Zhang <Jerry.Zhang@....com>, Monk Liu <Monk.Liu@....com>
Subject: Re: [patch] drm/amdgpu: potential NULL dereference in debugfs code

On Wed, Oct 12, 2016 at 5:20 AM, Christian König
<christian.koenig@....com> wrote:
> Am 12.10.2016 um 08:17 schrieb Dan Carpenter:
>>
>> debugfs_create_file() returns NULL on error, it only returns error
>> pointers if debugfs isn't enabled in the config and we checked for that
>> earlier so it can't happen.
>>
>> Fixes: 4f4824b55650 ('drm/amd/amdgpu: Convert ring debugfs entries to
>> binary')
>> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
>
> Reviewed-by: Christian König <christian.koenig@....com>.
>

Applied.  thanks!

Alex

>
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
>> index 85aeb0a..8d16eaf 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
>> @@ -371,8 +371,8 @@ static int amdgpu_debugfs_ring_init(struct
>> amdgpu_device *adev,
>>         ent = debugfs_create_file(name,
>>                                   S_IFREG | S_IRUGO, root,
>>                                   ring, &amdgpu_debugfs_ring_fops);
>> -       if (IS_ERR(ent))
>> -               return PTR_ERR(ent);
>> +       if (!ent)
>> +               return -ENOMEM;
>>         i_size_write(ent->d_inode, ring->ring_size + 12);
>>         ring->ent = ent;
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives