linux-kernel - Re: [PATCH] drivers: staging: greybus: audio_manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAs364-Djc=CEK4J+RkewS9t7VnKeHbwOVf-yTW_2+YyDhP9qA@mail.gmail.com>
Date:   Wed, 12 Oct 2016 11:29:13 +0530
From:   Vaibhav Agarwal <vaibhav.sr@...il.com>
To:     Chase Metzger <chasemetzger15@...il.com>
Cc:     Mark Greer <mgreer@...malcreek.com>,
        Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: greybus: audio_manager_sysfs.c: Fixed
 CHECK for brace issue

On Wed, Oct 12, 2016 at 4:52 AM, Chase Metzger <chasemetzger15@...il.com> wrote:
> Added braces to else and else if statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger <chasemetzger15@...il.com>
> ---
>  drivers/staging/greybus/audio_manager_sysfs.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybus/audio_manager_sysfs.c
> index d8bf859..376e17c 100644
> --- a/drivers/staging/greybus/audio_manager_sysfs.c
> +++ b/drivers/staging/greybus/audio_manager_sysfs.c
> @@ -71,10 +71,11 @@ static ssize_t manager_sysfs_dump_store(
>                 num = gb_audio_manager_dump_module(id);
>                 if (num)
>                         return num;
> -       } else if (!strncmp("all", buf, 3))
> +       } else if (!strncmp("all", buf, 3)) {
>                 gb_audio_manager_dump_all();
> -       else
> +       } else {
>                 return -EINVAL;
> +       }
>
>         return count;
>  }
> --
> 2.1.4
>
Reviewed-by: Vaibhav Agarwal <vaibhav.sr@...il.com>