linux-kernel - Re: [PATCH] drivers: staging: greybus: audio_topology.c: Fixed CHECKS for brace issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAs364_TyFRJyjHHjUrRTsHuQdQLOB=4qvaQKpBDSHAggC14gA@mail.gmail.com>
Date:   Wed, 12 Oct 2016 11:34:56 +0530
From:   Vaibhav Agarwal <vaibhav.sr@...il.com>
To:     Chase Metzger <chasemetzger15@...il.com>
Cc:     Mark Greer <mgreer@...malcreek.com>,
        Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: greybus: audio_topology.c: Fixed CHECKS
 for brace issues

On Wed, Oct 12, 2016 at 5:19 AM, Chase Metzger <chasemetzger15@...il.com> wrote:
> Added braces for else and else if statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger <chasemetzger15@...il.com>
> ---
>  drivers/staging/greybus/audio_topology.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio_topology.c
> index b625169..3a2678e 100644
> --- a/drivers/staging/greybus/audio_topology.c
> +++ b/drivers/staging/greybus/audio_topology.c
> @@ -1044,8 +1044,10 @@ static int gbaudio_tplg_create_widget(struct gbaudio_module_info *module,
>                         control->texts = (const char * const *)
>                                 gb_generate_enum_strings(module, gbenum);
>                         control->items = gbenum->items;
> -               } else
> +               } else {
>                         csize = sizeof(struct gb_audio_control);
> +               }
> +
>                 *w_size += csize;
>                 curr = (void *)curr + csize;
>                 list_add(&control->list, &module->widget_ctl_list);
> @@ -1190,8 +1192,9 @@ static int gbaudio_tplg_process_kcontrols(struct gbaudio_module_info *module,
>                         control->texts = (const char * const *)
>                                 gb_generate_enum_strings(module, gbenum);
>                         control->items = gbenum->items;
> -               } else
> +               } else {
>                         csize = sizeof(struct gb_audio_control);
> +               }
>
>                 list_add(&control->list, &module->ctl_list);
>                 dev_dbg(module->dev, "%d:%s created of type %d\n", curr->id,
> --
> 2.1.4
>
You have already submitted a similar patch available on staging-testing branch:
commit b7e0c9eca426 ("drivers: staging: greybus: Fixed CHECKS for brace issues")

--
thanks,
./va